Skip to content

Conversation

@KaloyanTanev
Copy link
Collaborator

Add histogram metric to track when charon received partial sig from peer compared to the earliest expected time.

Mind you that there might be differences when validator clients send their sync duties.

category: feature
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Jan 9, 2026
@KaloyanTanev KaloyanTanev added this to the v1.9.0 milestone Jan 9, 2026
@KaloyanTanev KaloyanTanev changed the title Store parsigdb metrics *: store parsigdb metrics Jan 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 35.00000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.95%. Comparing base (6426bd7) to head (b4f2c32).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 18 Missing ⚠️
eth2util/network.go 0.00% 5 Missing ⚠️
core/parsigdb/memory.go 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   56.96%   56.95%   -0.02%     
==========================================
  Files         237      237              
  Lines       30622    30659      +37     
==========================================
+ Hits        17445    17461      +16     
- Misses      10945    10970      +25     
+ Partials     2232     2228       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 13, 2026
@obol-bulldozer obol-bulldozer bot merged commit cf494ff into main Jan 13, 2026
11 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/stored-parsig-metric branch January 13, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants